Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Typed JobConfig #767

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[PoC] Typed JobConfig #767

wants to merge 7 commits into from

Conversation

jaysonfrancis
Copy link
Contributor

Incase theres any interest for type hinting of config args, at the expense of an added dependency (tyro).

Re; #753

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jan 1, 2025
@jaysonfrancis jaysonfrancis marked this pull request as ready for review January 4, 2025 00:31
@jaysonfrancis
Copy link
Contributor Author

  1. Fixes the following parsing issues

torchtitan/torchtitan/config_manager.py

Line 143 in 82f7387

# TODO: store_true & default=True make impossible for cmd to set it to False

torchtitan/torchtitan/config_manager.py

Lines 683 to 686 in 82f7387

# without this special case, type inference breaks here,
# since the inferred type is just 'list' and it ends up flattening
# e.g. from ["layers.0", "layers.1"] into ["l", "a", "y", "e", "r", "s", ".0", ...]
aux_parser.add_argument("--" + arg, type=string_list)

torchtitan/tests/unit_tests/test_job_config.py

Line 64 in 82f7387

# toml has no split points, but cmdline splits are specified

  1. Typing LSP support: image

  2. Fuzzy matching

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaysonfrancis @facebook-github-bot